[CRE-1492] allow tests to run EVM cap tests on two chains #20581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code left from refactor
Tofel
added
the
run-e2e-regression
Tofel
changed the title
Contributor
|
I see you updated files related to
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables EVM capability tests to run on two chains by removing single-chain constraints that were previously in place. The changes involve cleaning up commented code from a previous refactor, updating OCR3 contract deployment to use per-chain selectors instead of the registry chain selector, and enabling EVM capabilities on both chains (1337 and 2337) in the topology configurations.
Key Changes:
- Removed TODO comments and code that artificially limited tests to a single blockchain
- Modified OCR3 contract deployment to deploy contracts on each EVM chain instead of only on the registry chain
- Updated TOML configurations to enable EVM capability on both chains 1337 and 2337
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/smoke/cre/cre_suite_test.go | Removed single-chain limitations and TODO comments; added t.Skip() to multiple v2 test cases |
| system-tests/tests/regression/cre/cre_regression_suite_test.go | Removed single-chain blockchain filtering and associated TODO comments |
| system-tests/lib/cre/features/evm/v2/evm.go | Updated OCR3 deployment to use chain-specific selectors; removed large block of commented code; fixed typos |
| core/scripts/cre/environment/examples/workflows/v2/proof-of-reserve/cron-based/main.go | Changed hardcoded chain selector to use config value |
| core/scripts/cre/environment/examples/workflows/v2/proof-of-reserve/cron-based/go.mod | Removed unused chain-selectors dependency |
| core/scripts/cre/environment/configs/workflow-gateway-don.toml | Enabled EVM capability for both chains 1337 and 2337 |
| core/scripts/cre/environment/configs/workflow-gateway-capabilities-don.toml | Added chain configuration comments and enabled EVM on appropriate chains |
| core/scripts/cre/environment/configs/workflow-don.toml | Enabled EVM capability for both chains 1337 and 2337 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/scripts/cre/environment/configs/workflow-gateway-capabilities-don.toml
Outdated
Show resolved
Hide resolved
|
chudilka1
approved these changes
Dec 10, 2025
krehermann
approved these changes
Dec 10, 2025
george-dorin
approved these changes
Dec 10, 2025
Tofel
added a commit
that referenced
this pull request
Dec 11, 2025
* allow tests to run EVM cap tests on two chains, remove commented out code left from refactor * typos + removal of t.Skip()
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
* [CRE-1492] allow tests to run EVM cap tests on two chains (#20581) * allow tests to run EVM cap tests on two chains, remove commented out code left from refactor * typos + removal of t.Skip() * better messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and... remove commented out code left from refactor
and... deploy OCR3 contracts for EVM on each chain instead of the registry chain